Translate import declarations into calls to require() in beforeInit.#11
Closed
thomsbg wants to merge 2 commits intomarcello3d:masterfrom
Closed
Translate import declarations into calls to require() in beforeInit.#11thomsbg wants to merge 2 commits intomarcello3d:masterfrom
thomsbg wants to merge 2 commits intomarcello3d:masterfrom
Conversation
Import hrefs are assumed to be relative to the current file, and so
the call to require has `./` prepended. e.g.
<link rel="ractive" href="test.ract" />
require('./test.ract');
If a beforeInit callback was specified in the component, it will be
called after the sub-components have been set into options. See the
new test case for an example.
test/import.ract-output
Outdated
Owner
There was a problem hiding this comment.
I'm not familiar with how beforeInit works, is it possible for options.components to already exist at this point?
Author
There was a problem hiding this comment.
Hmm, yes I think so, if you were to instantiate your component like so: new CustomComponent({ components: { ... } })
I'll revise to not overwrite any passed in options.
Author
|
Ah, now I see #5. I didn't realize that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import hrefs are assumed to be relative to the current file, and so
the call to require has
./prepended. e.g.If a beforeInit callback was specified in the component, it will be
called after the sub-components have been set into options. See the
new test case for an example.
Also, I refactored things slightly to branching on
if (component.script). This causesvar component = moduleto always be output, and the use ofcomponent.exportsover justexports. Please let me know if that's a problem.